snuyanzin commented on a change in pull request #17899:
URL: https://github.com/apache/flink/pull/17899#discussion_r766268111



##########
File path: 
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java
##########
@@ -472,14 +472,12 @@
                                         LocalDateTime.of(2021, 9, 27, 12, 34, 
56, 123000000)
                                                 .atZone(CET)
                                                 .toInstant()))
-                        // https://issues.apache.org/jira/browse/FLINK-24446 
Fractional seconds are
-                        // lost
                         .fromCase(
                                 STRING(),
                                 CET_CONTEXT,
                                 StringData.fromString("2021-09-27 
12:34:56.123456789"),
                                 TimestampData.fromInstant(
-                                        LocalDateTime.of(2021, 9, 27, 12, 34, 
56, 0)
+                                        LocalDateTime.of(2021, 9, 28, 22, 52, 
32, 789000000)
                                                 .atZone(CET)

Review comment:
       May be a stupid question however could you please clarify why in String 
value there is 123456789 as fractions of seconds and in target 789000000 ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to