lindong28 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r765456269
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/linear/LogisticRegressionModelData.java ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.classification.linear; + +import org.apache.flink.api.common.serialization.Encoder; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.src.reader.SimpleStreamFormat; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.memory.DataInputViewStreamWrapper; +import org.apache.flink.core.memory.DataOutputViewStreamWrapper; +import org.apache.flink.ml.linalg.DenseVector; +import org.apache.flink.ml.linalg.typeinfo.DenseVectorSerializer; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.table.api.Table; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; +import org.apache.flink.table.api.internal.TableImpl; + +import java.io.EOFException; +import java.io.IOException; +import java.io.OutputStream; + +/** Model data of {@link LogisticRegressionModel}. */ +public class LogisticRegressionModelData { + + public final DenseVector coefficient; + + public LogisticRegressionModelData(DenseVector coefficient) { + this.coefficient = coefficient; + } + + /** + * Converts the table model to a data stream. + * + * @param modelData The table model data. + * @return The data stream model data. + */ + public static DataStream<LogisticRegressionModelData> getModelDataStream(Table modelData) { + StreamTableEnvironment tEnv = + (StreamTableEnvironment) ((TableImpl) modelData).getTableEnvironment(); + return tEnv.toDataStream(modelData).map(x -> (LogisticRegressionModelData) x.getField(0)); + } + + /** Data encoder for {@link LogisticRegressionModel}. */ + public static class ModelDataEncoder implements Encoder<LogisticRegressionModelData> { + + @Override + public void encode(LogisticRegressionModelData modelData, OutputStream outputStream) + throws IOException { + DenseVectorSerializer serializer = new DenseVectorSerializer(); + serializer.serialize( + modelData.coefficient, new DataOutputViewStreamWrapper(outputStream)); + } + } + + /** Data decoder for {@link LogisticRegressionModel}. */ + public static class ModelDataDecoder extends SimpleStreamFormat<LogisticRegressionModelData> { + + @Override + public Reader<LogisticRegressionModelData> createReader( + Configuration configuration, FSDataInputStream inputStream) { + return new Reader<LogisticRegressionModelData>() { + + @Override + public LogisticRegressionModelData read() throws IOException { + DenseVectorSerializer serializer = new DenseVectorSerializer(); Review comment: Could we make `serializer` a private member field of `Reader` so that we don't instantiate `serializer` repeatedly for every invocation of read()? Same for `ModelDataEncoder::encode()`. ########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/linear/LogisticRegressionModelData.java ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.ml.classification.linear; + +import org.apache.flink.api.common.serialization.Encoder; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.connector.file.src.reader.SimpleStreamFormat; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.memory.DataInputViewStreamWrapper; +import org.apache.flink.core.memory.DataOutputViewStreamWrapper; +import org.apache.flink.ml.linalg.DenseVector; +import org.apache.flink.ml.linalg.typeinfo.DenseVectorSerializer; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.table.api.Table; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; +import org.apache.flink.table.api.internal.TableImpl; + +import java.io.EOFException; +import java.io.IOException; +import java.io.OutputStream; + +/** Model data of {@link LogisticRegressionModel}. */ +public class LogisticRegressionModelData { + + public final DenseVector coefficient; + + public LogisticRegressionModelData(DenseVector coefficient) { + this.coefficient = coefficient; + } + + /** + * Converts the table model to a data stream. + * + * @param modelData The table model data. + * @return The data stream model data. + */ + public static DataStream<LogisticRegressionModelData> getModelDataStream(Table modelData) { + StreamTableEnvironment tEnv = + (StreamTableEnvironment) ((TableImpl) modelData).getTableEnvironment(); + return tEnv.toDataStream(modelData).map(x -> (LogisticRegressionModelData) x.getField(0)); + } + + /** Data encoder for {@link LogisticRegressionModel}. */ + public static class ModelDataEncoder implements Encoder<LogisticRegressionModelData> { + + @Override + public void encode(LogisticRegressionModelData modelData, OutputStream outputStream) + throws IOException { + DenseVectorSerializer serializer = new DenseVectorSerializer(); + serializer.serialize( + modelData.coefficient, new DataOutputViewStreamWrapper(outputStream)); + } + } + + /** Data decoder for {@link LogisticRegressionModel}. */ + public static class ModelDataDecoder extends SimpleStreamFormat<LogisticRegressionModelData> { Review comment: For code consistency, could you make change the corresponding class names to `ModelDataDecoder` for `KMeans` and `NaiveBayes` (after the NaiveBayes PR is merged)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
