luoyuxia commented on a change in pull request #17988:
URL: https://github.com/apache/flink/pull/17988#discussion_r762973447
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/ContinuousHiveSplitEnumerator.java
##########
@@ -93,6 +95,7 @@ public ContinuousHiveSplitEnumerator(
currentReadOffset,
seenPartitionsSinceOffset,
tablePath,
+ flinkConf,
Review comment:
As we only need `split.thread.num` in flinkConf, I think it maybe better
to pass a single value representing the `split.thread.num instead of passing
flinkconf.
It'll be more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
