MartijnVisser edited a comment on pull request #17676:
URL: https://github.com/apache/flink/pull/17676#issuecomment-986500834


   @leonardBang Are there any good examples from the other dialects that could 
be used to add more tests?
   
   Let me add a bit of background that I know. The test of `Postgresql `dialect 
is covered by `PostgresCatalogITCase`. This happened when the `Postgresql` 
catalog was introduced, the `Derby`  is a replacement of  `MySQL` dialect in 
tests. Yes, `Derby` was originally used as a test substitute for MySQL, the 
**testcontainer** has not been introduced yet in Flink at that time, all used 
resource are embeded instance.
   
   Back to this topic, I think we can change `JdbcDynamicTableSinkITCase` and 
`JdbcDynamicTableSourceITCase` to Parameterized tests for different dialects as 
the first step of tests reconstruction in this PR, then we can open a issue 
ticker to reconstruct the JDBC connector tests, the final goal is using 
testcontainer to replace embedded instances. How do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to