lindong28 commented on a change in pull request #28:
URL: https://github.com/apache/flink-ml/pull/28#discussion_r761595720
##########
File path:
flink-ml-core/src/main/java/org/apache/flink/ml/common/iteration/TerminateOnMaxIter.java
##########
@@ -27,16 +27,17 @@
* threshold.
*
* <p>When the output of this FlatMapFunction is used as the termination
criteria of an iteration
- * body, the iteration will be executed for at most the given `numRounds`
rounds.
+ * body, the iteration will be executed for at most the given `maxIter` rounds.
*
* @param <T> The class type of the input element.
*/
-public class TerminateOnMaxIterationNum<T>
+public class TerminateOnMaxIter<T>
Review comment:
Can we remove the `RoundBasedTerminationCriteria` entirely, and use
`TerminateOnMaxIter` in the test code instead?
"replace A with B" means that we can remove `A` and use `B` where `A` was
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
