dawidwys opened a new pull request #17968:
URL: https://github.com/apache/flink/pull/17968
## What is the purpose of the change
This PR unifies the code paths for stop-with-savepoint both with and without
drain.
## Brief change log
- EndOfData emitted both in case of stop-with-savepoint --drain and
--no-drain
- Stopping the source both with & without drain. We do not process data
after stop-with-savepoint
- Removed the synchronous loop. We always wait in the `afterInvoke` method.
## Verifying this change
* All existing tests passed.
* Removed a couple of tests which do no longer hold. They were testing for
corner case behaviours of stop-with-savepoint --no-drain which do no longer
hold.
* Modified
`testTriggerStopWithSavepointNoDrainWhenWaitingForFinalCheckpointOnSourceTask`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
**JavaDocs** / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
