link3280 opened a new pull request #17933:
URL: https://github.com/apache/flink/pull/17933
## What is the purpose of the change
Currently, JDBC connector assumes columns names respect Java identifier
naming restrictions, but databases that support JDBC may have different naming
restrictions. For example, MySQL allows dots and colons in column names. In
that case, JDBC connector would have trouble parsing the named parameters in
SQL.
This PR fixes the problem by adding enclosing parentheses to the named
parameters.
## Brief change log
- Add enclosing parentheses to the named parameters
- Escape reserved characters like ':'
## Verifying this change
Update existing tests to cover some corner cases.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
