zhipeng93 commented on a change in pull request #28: URL: https://github.com/apache/flink-ml/pull/28#discussion_r757198840
########## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasMaxIter.java ########## @@ -26,7 +26,7 @@ /** Interface for the shared maxIter param. */ public interface HasMaxIter<T> extends WithParams<T> { Param<Integer> MAX_ITER = - new IntParam("maxIter", "Maximum number of iterations.", 20, ParamValidators.gtEq(0)); + new IntParam("maxIter", "Maximum number of iterations.", 20, ParamValidators.gt(0)); Review comment: I prefer not. Is there a real use case for training a model iteratively while setting `MaxIterationNumber` to zero? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org