matriv commented on a change in pull request #17811:
URL: https://github.com/apache/flink/pull/17811#discussion_r756726143
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/UpdatableRowData.java
##########
@@ -17,23 +17,33 @@
package org.apache.flink.table.data;
+import org.apache.flink.annotation.Internal;
import org.apache.flink.table.data.binary.TypedSetters;
import org.apache.flink.types.RowKind;
+import java.util.BitSet;
+
/**
* An implementation of {@link RowData} which is backed by a {@link RowData}
and an updated Java
* object array.
*/
+@Internal
public final class UpdatableRowData implements RowData, TypedSetters {
private RowData row;
private final Object[] fields;
- private final boolean[] updated;
+ private final BitSet updated;
Review comment:
You could see some actual benefit, as the number of processed rows
increases, and especially if you have lots of fields select, (like in a `INSERT
INTO ... SELECT * FROM ...`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
