slinkydeveloper commented on a change in pull request #17898:
URL: https://github.com/apache/flink/pull/17898#discussion_r756658654
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/NoMatchingTableFactoryException.java
##########
@@ -28,6 +29,7 @@
import java.util.stream.Collectors;
/** Exception for not finding a {@link TableFactory} for the given properties.
*/
+@PublicEvolving
public class NoMatchingTableFactoryException extends RuntimeException {
Review comment:
I would rather prefer to move it where `FactoryUtil` in the `factory`
package, because this exception is a very specific exception which is used only
in a specific context. This package on the other hand has a wider scope and
audience. As a counter example, `ValidationException` and `TableException` IMO
fit this package since they're broad exceptions used by a wide range of APIs.
Same discussion applies for `AmbiguousTableFactoryException` and
`CatalogNotExistException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
