zentol opened a new pull request #17895: URL: https://github.com/apache/flink/pull/17895
In 3.2.2 a bug was fixed in the `shade-plugin` that resulted in it creating empty test jars if `shadeTestJar` was set to `true` and no prior `test-jar` was generated by the `maven-jar-plugin.` This caused the license check to fail, because it was setup to ignore empty test jars (as they are not interesting). Now that the test jars contained stuff (and I think even transitive dependencies), it expected a `NOTICE` file. However, we don't actually need/want the `shade-plugin` to shade the test-jars. It results in additional overhead in the build process, and it is highly advisable to not rely on those jars, because it is very easy to use them the wrong way as they do not come automatically with the transitive (and relocated) dependencies. As such this PR disables the shading of tests jars, with one exception being the kinesis connector, which still needs to relocate the test-jar for the e2e test. This test-jar exposes some utils, which call into the main jar (which is relocated), and thus also needs to be relocated. In the long-term we should get rid of this though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
