xuyangzhong commented on a change in pull request #17771:
URL: https://github.com/apache/flink/pull/17771#discussion_r752820224
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/SqlExpressionTest.scala
##########
@@ -302,23 +145,6 @@ class SqlExpressionTest extends ExpressionTestBase {
// Decimal(2,1) / Decimal(10,0) => Decimal(23,12)
testSqlApi("2.0/(-3)", "-0.666666666667")
testSqlApi("-7.9/2", "-3.950000000000")
-
- // invalid division
- val divisorZeroException = "Division by zero"
- testExpectedSqlException(
- "1/cast(0.00 as decimal)", divisorZeroException,
classOf[ArithmeticException])
- testExpectedSqlException(
- "1/cast(0.00 as double)", divisorZeroException,
classOf[ArithmeticException])
- testExpectedSqlException(
- "1/cast(0.00 as float)", divisorZeroException,
classOf[ArithmeticException])
- testExpectedSqlException(
- "1/cast(0 as tinyint)", divisorZeroException,
classOf[ArithmeticException])
- testExpectedSqlException(
- "1/cast(0 as smallint)", divisorZeroException,
classOf[ArithmeticException])
- testExpectedSqlException(
- "1/0", divisorZeroException, classOf[ArithmeticException])
- testExpectedSqlException(
- "1/cast(0 as bigint)", divisorZeroException,
classOf[ArithmeticException])
Review comment:
My mistake, I'll revert them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
