matriv edited a comment on pull request #17771: URL: https://github.com/apache/flink/pull/17771#issuecomment-968899489
Thx for taking care of this: @xuyangzhong I'd like to suggest some changes for those tests. - The validity of implicit tests is tested in `LogicalTypeCasts` and we should try and separate the test of if an implicit cast is valid to the actual cast conversion itself which is already testing in `CastFunctionITCase`. - If there are any new cases that deserve extra tests, those can be added directly in the main method `allTypesBasic`, or in a new method that tests corner cases similar to `CastFunctionITCase#numericBounds` This way, we don't bloat the integration test with tests that can be "unit tested". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
