xuyangzhong commented on a change in pull request #17734: URL: https://github.com/apache/flink/pull/17734#discussion_r748990493
########## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/interval/SemiAntiTimeIntervalJoin.java ########## @@ -0,0 +1,450 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.join.interval; + +import org.apache.flink.api.common.functions.RuntimeContext; +import org.apache.flink.api.common.state.MapState; +import org.apache.flink.api.common.state.MapStateDescriptor; +import org.apache.flink.api.common.state.StateTtlConfig; +import org.apache.flink.api.common.typeinfo.Types; +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.api.java.typeutils.MapTypeInfo; +import org.apache.flink.api.java.typeutils.TupleTypeInfo; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.streaming.api.functions.co.KeyedCoProcessFunction; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.runtime.generated.JoinCondition; +import org.apache.flink.table.runtime.typeutils.InternalTypeInfo; +import org.apache.flink.types.RowKind; +import org.apache.flink.util.Collector; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.apache.flink.table.runtime.util.StateConfigUtil.createTtlConfig; + +/** + * A CoProcessFunction to execute time interval (time-bounded) stream semi/anti-join. Two kinds of + * time criteria: "L.time between R.time + X and R.time + Y" or "R.time between L.time - Y and + * L.time - X" X and Y might be negative or positive and X <= Y. + */ +public abstract class SemiAntiTimeIntervalJoin Review comment: The main difference is the following: 1. different states with left and right stream. 2. different logic in `processElement1` and `processElement2` It seems that if I use the existing strategy in `TimeIntervalJoin` to clean up states, the most methods can be reused just like you say. So maybe I can get an higher abstract class named `TimeIntervalJoin` to keep the most codes and transfer the remaining codes in `TimeIntervalJoin` to `CommonTimeIntervalJoin`. And do semi / anti join in `SemiAntiTimeIntervalJoin`. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
