curcur commented on pull request #17462: URL: https://github.com/apache/flink/pull/17462#issuecomment-966795230
> Thanks for the PR @curcur, I've left some comments, PTAL. > > PR description says it's verified by unit tests, but I couldn't find any (and the existing tests don't cover the change I believe). The existing unit tests including a piece of materialized snapshot + non-materialized changelog Recovery comes from both materialized snapshot + non-materialized changelog It can not recover correctly if meta is missing. > Commit messages are missing component; it's optional, but just "write metadata after materialization` is very abstract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
