akalash commented on a change in pull request #17660:
URL: https://github.com/apache/flink/pull/17660#discussion_r745692850
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java
##########
@@ -64,6 +64,8 @@
private TimerGauge backPressuredTimeMsPerSecond = new TimerGauge();
+ private long totalWrittenBytes;
Review comment:
Of course, we can rewrite the metric in such a way that instead of
passing the counter it can call the method for receiving the number of bytes.
But it definitely is not one line change and if we do so unfortunately semantic
for `numBuffersOut` and `numBytesOut` will be different which is not tragic but
anyway.
So we can do this but I don't sure that it makes sense to do it here. Or do
you think that the separate commit under this ticket is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
