Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69266892
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.streaming.connectors.redis.common.container;
+
+import org.apache.flink.util.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import redis.clients.jedis.JedisCluster;
+
+import java.io.Closeable;
+import java.io.IOException;
+
+/**
+ * Redis command container if we want to connect to a Redis cluster.
+ */
+public class RedisClusterContainer implements RedisCommandsContainer,
Closeable {
+
+ private static final long serialVersionUID = 1L;
+
+ private static final Logger LOG =
LoggerFactory.getLogger(RedisClusterContainer.class);
+
+ private JedisCluster jedisCluster;
+
+ /**
+ * Initialize Redis command container for Redis cluster.
+ *
+ * @param jedisCluster JedisCluster instance
+ */
+ public RedisClusterContainer(JedisCluster jedisCluster) {
+ Preconditions.checkNotNull(jedisCluster, "Jedis cluster can not
be null");
+
+ this.jedisCluster = jedisCluster;
+ }
+
+ @Override
+ public void hset(final String key, final String hashField, final String
value) {
+ try {
+ jedisCluster.hset(key, hashField, value);
+ } catch (Exception e) {
--- End diff --
From the look of the Jedis code, all exceptions thrown by Jedis are
`RuntimeException`s:
https://github.com/xetorthio/jedis/tree/master/src/main/java/redis/clients/jedis/exceptions,
so the API isn't informing to expect any exceptions to catch.
I think for this first version on the Redis Sink, we should simply fail
(and log the failure) by rethrowing the exception. For users I think it'd be
better to offer "simply log failure and not hard fail" as a user option, like
what the Kafka producer does (we can perhaps add this functionality later on).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
