wsz94 removed a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-958691150
> I don't think this fixed the data loss issue. Pulsar [internally wrap](https://github.com/apache/pulsar/blob/f0413b1adad395319e5595a863764f8af943dbe8/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L422) the CompletableFuture in `receiveAsync()` with a `CompletableFutureCancellationHandler`. The pending receiver would be automatically removed when meeting `TimeoutException`. > > That means we don't meet data loss when we don't manually cancel the future. > > @AHeise Can you confirm this? I think that you are wrong. The CompletableFutureCancellationHandler > [internally](https://github.com/apache/pulsar/blob/f0413b1adad395319e5595a863764f8af943dbe8/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L422) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
