tsreaper commented on a change in pull request #17605:
URL: https://github.com/apache/flink/pull/17605#discussion_r741595404
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/rank/UpdatableTopNFunction.java
##########
@@ -312,6 +355,46 @@ private void processElementWithRowNumber(RowData inputRow,
Collector<RowData> ou
"Failed to find the sortKey, rowkey in the buffer. This should
never happen");
}
+ private void emitRecordsWithRowNumberIgnoreStateError(
+ RowData newSortKey,
+ RowData newRow,
+ int newRank,
+ RowData oldSortKey,
+ RankRow oldRow,
+ int oldRank,
+ Collector<RowData> out) {
+ Iterator<Map.Entry<RowData, Collection<RowData>>> iterator =
buffer.entrySet().iterator();
+ int currentRank = 0;
+ RowData currentRow = null;
+ RowData prevRow = null;
+
+ while (iterator.hasNext() && currentRank <= newRank) {
+ Map.Entry<RowData, Collection<RowData>> entry = iterator.next();
+ RowData curSortKey = entry.getKey();
+ Collection<RowData> rowKeys = entry.getValue();
+ Iterator<RowData> rowKeyIter = rowKeys.iterator();
+ while (rowKeyIter.hasNext()) {
+ RowData rowKey = rowKeyIter.next();
+ currentRank += 1;
+ currentRow = rowKeyMap.get(rowKey).row;
+ if (oldRank <= currentRank) {
+ if (currentRank == oldRank) {
+ checkArgument(0 ==
sortKeyComparator.compare(curSortKey, oldSortKey));
Review comment:
Why is this true? It might be that the `oldSortKey` is unique and after
the change it does not exist anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
