twalthr commented on a change in pull request #17652:
URL: https://github.com/apache/flink/pull/17652#discussion_r741897754
##########
File path:
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/nodes/exec/stream/TableSourceJsonPlanTest_jsonplan/testPartitionPushDown.out
##########
@@ -64,7 +61,7 @@
"b" : "INT"
} ]
},
- "description" : "TableSourceScan(table=[[default_catalog,
default_database, PartitionTable, filter=[], partitions=[{p=A}], project=[a,
b], metadata=[]]], fields=[a, b])",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, PartitionTable, partitions=[{p=A}], project=[a, b],
metadata=[]]], fields=[a, b])",
Review comment:
Watermarks and filters are a tricky topic anyway, because if the filter
is too good, you will have almost no progress in event-time anymore. Let's open
a follow up issue for this. I think having a clear spec order could be
beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
