matriv opened a new pull request #17634:
URL: https://github.com/apache/flink/pull/17634
## What is the purpose of the change
Fix precision for sum on decimal types, as previously the logic in
`LogicalTypeMerging`
were not following 100% the rules described in Microsoft's t-sql
documentation.
## Brief change log
- Changed the corresponding method for multiplication & division to
conform to
the t-sql rules
- Introduced a new method which adjusts the scale in case of addition (&
subtraction)
where the logic is different from the adjustment needed for multiplication &
division.
## Verifying this change
This change added tests and can be verified as follows:
- Added `LogicalTypeMergingTest` class to test the output decimal types
for the arithmetic operations.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
