[ 
https://issues.apache.org/jira/browse/FLINK-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355292#comment-15355292
 ] 

Greg Hogan commented on FLINK-3879:
-----------------------------------

Hi [~vkalavri], good to have you back!

I appreciate your confidence. Have I correctly surmised that you are the only 
other current reviewer of Gelly PRs? I also prefer code reviews, but the noted 
algorithms would not be available in the 1.1 release if I had not triple-washed 
and merged the code. There was no dissension on these tickets and all review 
comments were resolved.

If we need to improve our process I'd suggest starting at the top by keeping a 
clean sheet of Jira tickets. Ideas should be reserved for the Gelly roadmap, 
and any Jira ticket should be ready for and hopefully initiate a conversation 
discussing implementation details. It should be decided upfront or as early as 
possible whether to accept or reject a feature or improvement. With 
HITSAlgorithm it was identified early in the review that performance would 
likely be better using GSA and that performance would be degraded due to 
duplicating edges.

+1 for collaboration, +1 for conversations, +1 for code reviews

> Native implementation of HITS algorithm
> ---------------------------------------
>
>                 Key: FLINK-3879
>                 URL: https://issues.apache.org/jira/browse/FLINK-3879
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>             Fix For: 1.1.0
>
>
> Hyperlink-Induced Topic Search (HITS, also "hubs and authorities") is 
> presented in [0] and described in [1].
> "[HITS] is a very popular and effective algorithm to rank documents based on 
> the link information among a set of documents. The algorithm presumes that a 
> good hub is a document that points to many others, and a good authority is a 
> document that many documents point to." 
> [https://pdfs.semanticscholar.org/a8d7/c7a4c53a9102c4239356f9072ec62ca5e62f.pdf]
> This implementation differs from FLINK-2044 by providing for convergence, 
> outputting both hub and authority scores, and completing in half the number 
> of iterations.
> [0] http://www.cs.cornell.edu/home/kleinber/auth.pdf
> [1] https://en.wikipedia.org/wiki/HITS_algorithm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to