iyupeng commented on a change in pull request #17344:
URL: https://github.com/apache/flink/pull/17344#discussion_r738893985
##########
File path:
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala
##########
@@ -1002,6 +1001,12 @@ abstract class TableTestUtil(
.getConfiguration
.set(ExecutionOptions.BATCH_SHUFFLE_MODE,
BatchShuffleMode.ALL_EXCHANGES_PIPELINED)
+ // Disable push down aggregates to avoid conflicts with existing test cases
that verify plans.
+ tableEnv.getConfig
+ .getConfiguration
+ .setBoolean(
+
OptimizerConfigOptions.TABLE_OPTIMIZER_SOURCE_AGGREGATE_PUSHDOWN_ENABLED, false)
Review comment:
Hello @godfreyhe, thanks for the comments.
2 existing test cases with `local aggregate` and `'connector' = 'values'`
can be affected if we enable `aggregate push down`:
1. RankTest.scala#L172, `testCreateViewWithRowNumber`
2. TableSourceTest.scala#L118, `testProjectWithoutInputRef`
We need to change the plans of these 2 test cases in `.xml` files if we
remove above configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
