matriv commented on a change in pull request #17579:
URL: https://github.com/apache/flink/pull/17579#discussion_r738279632
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -191,149 +210,159 @@ protected Configuration configuration() {
.failTableApi(FLOAT(), -123.456)
.failTableApi(DOUBLE(), 0)
// Not supported - no fix
- // DATE
- // TIME
- // TIMESTAMP
+ .fail(DATE(), LocalDate.of(2021, 10, 26))
+ .fail(TIME(), LocalTime.parse("12:34:56.123"))
+ .fail(TIMESTAMP(),
LocalDateTime.parse("2021-09-24T12:34:56.123456"))
// TIMESTAMP_WITH_TIME_ZONE
- // TIMESTAMP_LTZ
- // INTERVAL_YEAR_MONTH
- // INTERVAL_DAY_TIME
- // ARRAY
+ .fail(TIMESTAMP_LTZ(),
fromLocalTZ("2021-09-24T18:34:56.123456"))
+ .fail(INTERVAL(YEAR(), MONTH()), Period.of(10, 4, 0))
+ .fail(INTERVAL(DAY(), SECOND()), Duration.ofHours(12))
+ .fail(ARRAY(INT()), new int[] {0, 1, 2})
// MULTISET
// MAP
// ROW
// RAW
.build(),
CastTestSpecBuilder.testCastTo(BINARY(2))
+ .fromCase(BINARY(5), null, null)
.fromCase(CHAR(3), "foo", new byte[] {102, 111, 111})
.fromCase(VARCHAR(5), "Flink", new byte[] {70, 108,
105, 110, 107})
// https://issues.apache.org/jira/browse/FLINK-24419 -
not trimmed to 2
// bytes
.fromCase(STRING(), "Apache", new byte[] {65, 112, 97,
99, 104, 101})
// Not supported - no fix
- // BOOLEAN
+ .fail(BOOLEAN(), randomBoolean())
+ //
.fromCase(BINARY(2), new byte[] {0, 1}, new byte[] {0,
1})
.fromCase(VARBINARY(3), new byte[] {0, 1, 2}, new
byte[] {0, 1, 2})
.fromCase(BYTES(), new byte[] {0, 1, 2, 3, 4}, new
byte[] {0, 1, 2, 3, 4})
// Not supported - no fix
- // DECIMAL
- // TINYINT
- // SMALLINT
- // INT
- // BIGINT
- // FLOAT
- // DOUBLE
- // DATE
- // TIME
- // TIMESTAMP
+ .fail(DECIMAL(5, 3), 12.345)
+ .fail(TINYINT(), (byte) 5)
+ .fail(SMALLINT(), (short) 12)
+ .fail(INT(), 122345)
+ .fail(BIGINT(), 12345678912L)
+ .fail(FLOAT(), 1.2345)
+ .fail(DOUBLE(), 1.23456789)
+ .fail(DATE(), LocalDate.of(2021, 10, 26))
+ .fail(TIME(), LocalTime.parse("12:34:56.123"))
+ .fail(TIMESTAMP(),
LocalDateTime.parse("2021-09-24T12:34:56.123456"))
// TIMESTAMP_WITH_TIME_ZONE
- // TIMESTAMP_LTZ
- // INTERVAL_YEAR_MONTH
- // INTERVAL_DAY_TIME
- // ARRAY
+ .fail(TIMESTAMP_LTZ(),
fromLocalTZ("2021-09-24T18:34:56.123456"))
+ .fail(INTERVAL(YEAR(), MONTH()), Period.of(10, 4, 0))
+ .fail(INTERVAL(DAY(), SECOND()), Duration.ofHours(12))
+ .fail(ARRAY(INT()), new int[] {0, 1, 2})
Review comment:
Nice idea, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
