[
https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354805#comment-15354805
]
ASF GitHub Bot commented on FLINK-4127:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r68905853
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to remove from containers (YARN / Mesos),
to compensate
* for other JVM memory usage.
*/
- public static final String CONTAINERED_HEAP_CUTOFF_RATIO =
"containered.heap-cutoff-ratio";
+ public static final String CONTAINER_HEAP_CUTOFF_RATIO =
"container.heap-cutoff-ratio";
/**
* Minimum amount of heap memory to remove in containers, as a safety
margin.
*/
- public static final String CONTAINERED_HEAP_CUTOFF_MIN =
"containered.heap-cutoff-min";
+ public static final String CONTAINER_HEAP_CUTOFF_MIN =
"container.heap-cutoff-min";
/**
* Prefix for passing custom environment variables to Flink's master
process.
* For example for passing LD_LIBRARY_PATH as an env variable to the
AppMaster, set:
* yarn.application-master.env.LD_LIBRARY_PATH: "/usr/lib/native"
* in the flink-conf.yaml.
*/
- public static final String CONTAINERED_MASTER_ENV_PREFIX =
"containered.application-master.env.";
+ public static final String CONTAINER_MASTER_ENV_PREFIX =
"container.application-master.env.";
--- End diff --
How about we rename the config string to `container.master.env`?
> Clean up configuration and check breaking API changes
> -----------------------------------------------------
>
> Key: FLINK-4127
> URL: https://issues.apache.org/jira/browse/FLINK-4127
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
> Attachments: flink-core.html, flink-java.html, flink-scala.html,
> flink-streaming-java.html, flink-streaming-scala.html
>
>
> For the upcoming 1.1. release, I'll check if there are any breaking API
> changes and if the documentation is up tp date with the configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
