XComp commented on a change in pull request #17518:
URL: https://github.com/apache/flink/pull/17518#discussion_r735318653
##########
File path: docs/README.md
##########
@@ -103,14 +103,14 @@ to its documentation markdown. The following are
available for use:
#### Flink Artifact
- {{< artifact flink-streaming-java withScalaVersion >}}
+ {{< artifact flink-streaming-scala withScalaVersion >}}
This will be replaced by the maven artifact for flink-streaming-java that
users should copy into their pom.xml file. It will render out to:
Review comment:
I guess, here we should use `flink-streaming-scala` now as well
##########
File path: docs/content/docs/connectors/datastream/pubsub.md
##########
@@ -30,7 +30,7 @@ This connector provides a Source and Sink that can read from
and write to
[Google Cloud PubSub](https://cloud.google.com/pubsub). To use this connector,
add the
following dependency to your project:
-{{< artifact flink-connector-gcp-pubsub withScalaVersion >}}
Review comment:
This isn't changed in the Chinese version of the docs
##########
File path: flink-formats/flink-avro-glue-schema-registry/pom.xml
##########
@@ -94,6 +94,7 @@ under the License.
<groupId>software.amazon.glue</groupId>
<artifactId>schema-registry-serde</artifactId>
<version>${glue.schema.registry.version}</version>
+ <!-- This has a transitive dependency on
mbknor-jackson-jsonschema which needs scala -->
Review comment:
Why do we put the comment below the definition? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
