[
https://issues.apache.org/jira/browse/FLINK-24381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433696#comment-17433696
]
Ada Wong edited comment on FLINK-24381 at 10/25/21, 11:26 AM:
--------------------------------------------------------------
As [~chesnay] comment in PR, could I directly use
GlobalConfiguration#isSensitive to judge sensitive options in FactoryUtil? I
don't have to add a isSecret flag.
was (Author: ana4):
As [~chesnay] comment in PR, could I directly use
GlobalConfiguration#isSensitive to judge sensitive options in FactoryUtil?
> Hidden password value when Flink SQL connector throw exception.
> ---------------------------------------------------------------
>
> Key: FLINK-24381
> URL: https://issues.apache.org/jira/browse/FLINK-24381
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Planner
> Affects Versions: 1.13.2
> Reporter: Ada Wong
> Assignee: Ada Wong
> Priority: Major
> Labels: pull-request-available
>
> This following is error message. Password is 'bar' and is displayed.
> Could we hidden it to password='******' or password='<hidden>' inspired by
> Apache Kafka source code.
> {code:java}
> Missing required options are:
> hosts
> Unable to create a sink for writing table
> 'default_catalog.default_database.dws'.
> Table options are:
> 'connector'='elasticsearch7-x'
> 'index'='foo'
> 'password'='bar'
> at
> org.apache.flink.table.factories.FactoryUtil.createTableSink(FactoryUtil.java:208)
> at
> org.apache.flink.table.planner.delegation.PlannerBase.getTableSink(PlannerBase.scala:369)
> at
> org.apache.flink.table.planner.delegation.PlannerBase.translateToRel(PlannerBase.scala:221)
> at
> org.apache.flink.table.planner.delegation.PlannerBase.$anonfun$translate$1(PlannerBase.scala:159
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
