fapaul commented on a change in pull request #17501:
URL: https://github.com/apache/flink/pull/17501#discussion_r732562392
##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -26,7 +26,7 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-formats</artifactId>
<version>1.15-SNAPSHOT</version>
- <relativePath>..</relativePath>
+ <relativePath>../pom.xml</relativePath>
Review comment:
> Thanks for asking. Using StreamFormat will enable streaming process
for parquet file source. Further more, the same implementation can be used in
batch processing via adapter too, please refer to e.g. StreamFormatAdapter.
Afaik, this is one of the good design coming with the new FileSource.
I do not think that `StreamFormat` has a relation to the batch or stream
execution. It should only be based on the different format implementation. The
`BulkFormat` was specifically designed to support Orc and Parquet use cases in
batch and streaming. Therefore introducing a new `StreamFormat` to support a
parquet feels wrong. Can you elaborate more on why you chose the `StreamFormat`
instead of implementing the `BulkFormat`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
