pnowojski commented on a change in pull request #17471:
URL: https://github.com/apache/flink/pull/17471#discussion_r728983541
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -105,9 +105,7 @@
private static final Logger LOG =
LoggerFactory.getLogger(StreamingJobGraphGenerator.class);
- private static final long DEFAULT_NETWORK_BUFFER_TIMEOUT = 100L;
-
- public static final long UNDEFINED_NETWORK_BUFFER_TIMEOUT = -1L;
+ public static final long DISABLED_NETWORK_BUFFER_TIMEOUT = -1L;
Review comment:
Good point, but `StreamingJobGraphGenerator` doesn't sound like a good
place for this constant. Shouldn't it be in `TaskManagerOptions` or some other
class in `flink-core`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
