dawidwys opened a new pull request #17471:
URL: https://github.com/apache/flink/pull/17471


   ## What is the purpose of the change
   The goal is to fix the possibility to disable buffer timeout for pipelined 
exchanges. It has been broken in #13209, which was supposed to add a check that 
buffer timeout is properly configured if blocking exchanges are present in the 
graph.
   
   
   ## Brief change log
   
   * treat -1 again as a valid configuration instead of `UNDEFINED`
   * it disables the automatic disabling of buffer timeout for blocking 
exchanges
   
   ## Verifying this change
   
   Tests in `StreamingJobGraphGeneratorTest` work. I also added 
`org.apache.flink.streaming.api.graph.StreamingJobGraphGeneratorTest#testDisablingBufferTimeoutWithPipelinedExchanges`
 to verify we can disable buffer timeout for pipelined exchanges.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to