[ 
https://issues.apache.org/jira/browse/FLINK-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350720#comment-15350720
 ] 

ASF GitHub Bot commented on FLINK-4121:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2165
  
    I think it would be better to only have one place in the doc where we say 
that timestamps/watermarks are in milliseconds (with a red warning box, so it's 
visible). I can change it while merging


> Add timeunit (ms) to docs for timestamps and watermarks
> -------------------------------------------------------
>
>                 Key: FLINK-4121
>                 URL: https://issues.apache.org/jira/browse/FLINK-4121
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Jonas Traub
>            Priority: Trivial
>
> I'm teaching a class where students are supposed to implement Flink streaming 
> programs. It seems to be unclear for them, that the time unit of timestamps 
> and watermarks is milliseconds.
> They just see TimeWindow.seconds(...) or something similar and assume the 
> timestamps to be of the same unit (seconds) which is obviously not the case.
> I just checked the documentation and there is no explicit specification of 
> the time unit used for timestamps.
> After short talk with [~aljoscha], I'll open a mini-PR to address this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to