[ 
https://issues.apache.org/jira/browse/FLINK-23653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nico Kruber closed FLINK-23653.
-------------------------------
    Fix Version/s: 1.13.3
       Resolution: Fixed

Fixed on master via bbb051ac458e1555f76f396f9424337d27cf4fd6

> improve training exercises and tests so they are better examples
> ----------------------------------------------------------------
>
>                 Key: FLINK-23653
>                 URL: https://issues.apache.org/jira/browse/FLINK-23653
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation / Training / Exercises
>    Affects Versions: 1.13.2
>            Reporter: David Anderson
>            Assignee: David Anderson
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.13.3
>
>
> The tests for the training exercises are implemented in a way that permits 
> the same tests to be used for both the exercises and the solutions, and for 
> both the Java and Scala implementations. The way that this was done is a bit 
> awkward. 
> It would be better to
>  * eliminate the ExerciseBase class and its mechanisms for setting the 
> source(s) and sink and parallelism
>  * have tests that run with parallelism > 1
>  * speed up the tests by using MiniClusterWithClientResource
> It's also the case that the watermarking is done by calling emitWatermark in 
> the sources. This is confusing; the watermarking should be visibly 
> implemented in the exercises and solutions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to