Airblader commented on a change in pull request #17332:
URL: https://github.com/apache/flink/pull/17332#discussion_r720673107
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java
##########
@@ -142,4 +143,16 @@
*/
String getSelectFromStatement(
String tableName, String[] selectFields, String[] conditionFields);
+
+ /** Create catalog instance. */
+ default AbstractJdbcCatalog createCatalog(
+ String catalogName,
Review comment:
Because AbstractJdbcCatalog is currently not a public API, but with your
PR it becomes one. Therefore it must have a good design or else we'll be forced
to break the API in the future, which is exactly what we need to avoid. Since
we're just walking in circles here, can you explain why you want to move this
to a separate issue? It only creates a big risk of releasing a bad API because
no one implements the follow-up issue. Things should have the proper quality
when they hit master, not when a release is created. It's also not a very big
change, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
