[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349615#comment-15349615
]
ASF GitHub Bot commented on FLINK-3034:
---------------------------------------
Github user mjsax commented on the issue:
https://github.com/apache/flink/pull/1813
@tzulitai Thank a lot for testing this! Your feedback is really great!
1) I am not a Redis users either -- from my understanding, the second key
determined the field that would be updated -- it makes sense to me, that this
field is the same for all updates (ie, independent of the data itself). Thus,
it would not make sense to extract it from the record via `RedisMapper`.
2) Might be confusing for Redis users (I did not stumble over it as a
no-user ;)) -- renaming seems reasonable -- maybe `RedisSinkConfig` ?
3+4) Well, the data type is the same, no matter if you want to read or
write it. But I agree, that using the date type itself in `RedisSink` might not
be sufficient. I think the idea to support `LPUSH` was, that Flink as a
streaming system might do best to append at the tail, not at the head...
5) Similar to my answer to (4) -- the data type is the same --
independently what operation you perform on it. And you state yourself, that
`RedisMapper` maps the type to the command/action.
6) See my answer to (1)
As a non-Redis users, it is hard for me to judge what flexibility is
required/expected by users (ie, secondary key per record or not?). It also
seems, that not all available action (LPUSH vs RPUSH) are implemented. How
important is it, to support all action -- do you think, that the current once
cover the most basic subset to get started with. It might be good, to just
start with a subset of commands, and add new commands later on (just a
suggestion). And do the think the implemented actions for each type are the
most useful? If we want to support multiple different actions per data type, it
would be a larger refactoring of this code I think.
@subhankarb @rmetzger What is your opinion on this?
> Redis SInk Connector
> --------------------
>
> Key: FLINK-3034
> URL: https://issues.apache.org/jira/browse/FLINK-3034
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Matthias J. Sax
> Assignee: Subhankar Biswas
> Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
