[
https://issues.apache.org/jira/browse/FLINK-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422825#comment-17422825
]
Till Rohrmann commented on FLINK-15816:
---------------------------------------
I agree that implicit behaviour, such as truncating the configured cluster-id,
is not desirable because it makes the system harder to understand. On the other
hand, the failure happens rather late and it is also some internal value that
the user will probably not interact with. Hence, I could see two possible
improvements:
a) Check the validity of all values when creating the K8s HA services and fail
fast if some constraints are violated (e.g. cluster id is too long)
b) Truncate the labels we write into the config maps and state this behaviour
in the documentation
> Limit the maximum length of the value of kubernetes.cluster-id configuration
> option
> -----------------------------------------------------------------------------------
>
> Key: FLINK-15816
> URL: https://issues.apache.org/jira/browse/FLINK-15816
> Project: Flink
> Issue Type: Sub-task
> Components: Deployment / Kubernetes
> Affects Versions: 1.10.0, 1.14.1
> Reporter: Canbin Zheng
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Attachments: image-2020-01-31-20-54-33-340.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two Kubernetes Service will be created when a session cluster is deployed,
> one is the internal Service and the other is the rest Service, we set the
> internal Service name to the value of the _kubernetes.cluster-id_
> configuration option and then set the rest Service name to
> _${kubernetes.cluster-id}_ with a suffix *-rest* appended, said if we set the
> _kubernetes.cluster-id_ to *session-test*, then the internal Service name
> will be *session-test* and the rest Service name be *session-test-rest;*
> there is a constraint in Kubernetes that the Service name must be no more
> than 63 characters, for the current naming convention it leads to that the
> value of _kubernetes.cluster-id_ should not be more than 58 characters,
> otherwise there are scenarios that the internal Service is created
> successfully then comes up with a ClusterDeploymentException when trying to
> create the rest Service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
