lindong28 commented on pull request #4: URL: https://github.com/apache/flink-ml/pull/4#issuecomment-926624833
@becketqin After looking into the package path issue, I think the CI is actually working correctly. Here is what I find: 1) I have tried `mvn package` with that package path locally and it works. So the CI is working as expected. 2) Previously the file PipelineModel.java defines the `PipelineModel` class under the package path `org.apache.flink.ml.api.pipeline`. And all other classes (e.g.`Pipeline`) imports the `PipelineModel` class using the package path `org.apache.flink.ml.api.pipeline`. This could explain why `mvn package` works. 3) What puzzled us is the fact that the class `org.apache.flink.ml.api.pipeline.PipelineModel` is defined in the file with path `org/apache/flink/ml/api/core/PipelineModel.java`. However, after searching related information on Google, I find no document that says the package path of a class must be consistent with the path of the file that defines the class. So that setup is technically OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
