dawidwys commented on a change in pull request #17253:
URL: https://github.com/apache/flink/pull/17253#discussion_r714768230
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -820,16 +796,13 @@ private void doRun() {
|| current == ExecutionState.DEPLOYING) {
if (t instanceof CancelTaskException) {
if (transitionState(current,
ExecutionState.CANCELED)) {
- cancelInvokable(invokable);
break;
}
} else {
if (transitionState(current,
ExecutionState.FAILED, t)) {
// proper failure of the task. record the
exception as the root
// cause
failureCause = t;
- cancelInvokable(invokable);
-
break;
Review comment:
Can we end up here? Isn't it the case that if there is an exception we
will return from `restoreAndInvoke` in either `CANCELLING` or `FAILED` state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
