[ 
https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345779#comment-15345779
 ] 

ASF GitHub Bot commented on FLINK-1979:
---------------------------------------

Github user chiwanpark commented on the issue:

    https://github.com/apache/flink/pull/1985
  
    Hi @skavulya, sorry for late response. I've checked the updated PR and 
looks good to me. I wonder whether the name `RegularizationPenalty` is proper 
because the class calculates lots of values. But it is trivial thing.
    
    If there is no objection in few days, I'll merge this. Thanks! 👍 


> Implement Loss Functions
> ------------------------
>
>                 Key: FLINK-1979
>                 URL: https://issues.apache.org/jira/browse/FLINK-1979
>             Project: Flink
>          Issue Type: Improvement
>          Components: Machine Learning Library
>            Reporter: Johannes Günther
>            Assignee: Johannes Günther
>            Priority: Minor
>              Labels: ML
>
> For convex optimization problems, optimizer methods like SGD rely on a 
> pluggable implementation of a loss function and its first derivative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to