Airblader edited a comment on pull request #17133:
URL: https://github.com/apache/flink/pull/17133#issuecomment-919799883


   @zentol In that case we probably need to more clearly define how annotations 
should be used in the project first as we'd very strictly want to forbid any 
new violations rather than use it as a guide and way to make possible 
unintentional violations visible. 
   
   Currently, modules like flink-core and flink-table seem to have a very 
different understanding of how annotations should be used. Core heavily 
annotates all nested classes, not just top-level ones. Also, would that mean 
that methods are allowed to be annotated with any less-stable annotation than 
their top-level class in general (including `@Internal`)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to