fapaul commented on a change in pull request #17271: URL: https://github.com/apache/flink/pull/17271#discussion_r708911611
########## File path: flink-end-to-end-tests/flink-end-to-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/common/FlinkContainerWithPulsarEnvironment.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.tests.util.pulsar.common; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.MemorySize; +import org.apache.flink.tests.util.TestUtils; +import org.apache.flink.tests.util.flink.FlinkContainerTestEnvironment; + +import static org.apache.flink.configuration.TaskManagerOptions.TASK_OFF_HEAP_MEMORY; + +/** A Flink Container which would bundles pulsar connector in its classpath. */ +public class FlinkContainerWithPulsarEnvironment extends FlinkContainerTestEnvironment { + + public FlinkContainerWithPulsarEnvironment(int numTaskManagers, int numSlotsPerTaskManager) { + super( + numTaskManagers, + numSlotsPerTaskManager, + resourcePath("pulsar-connector.jar"), + resourcePath("pulsar-client-all.jar"), + resourcePath("pulsar-client-api.jar"), + resourcePath("pulsar-admin-api.jar"), + resourcePath("jul-to-slf4j.jar")); + } + + private static String resourcePath(String jarName) { + return TestUtils.getResource(jarName).toAbsolutePath().toString(); + } + + @Override + protected Configuration flinkConfiguration() { + Configuration configuration = super.flinkConfiguration(); + // Increase the off heap memory for avoiding direct buffer memory error on Pulsar e2e tests. + configuration.set(TASK_OFF_HEAP_MEMORY, MemorySize.ofMebiBytes(100)); Review comment: Did you already open a ticket to fix this properly? I think we also need to update the release notes to mention the pulsar source is for now only supporting Java 8. FYI @dawidwys ########## File path: flink-end-to-end-tests/flink-end-to-end-tests-pulsar/src/test/java/org/apache/flink/tests/util/pulsar/common/UnorderedSourceTestSuiteBase.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.tests.util.pulsar.common; + +import org.apache.flink.api.common.eventtime.WatermarkStrategy; +import org.apache.flink.api.connector.source.Boundedness; +import org.apache.flink.api.connector.source.Source; +import org.apache.flink.connectors.test.common.environment.TestEnvironment; +import org.apache.flink.connectors.test.common.external.ExternalContext; +import org.apache.flink.connectors.test.common.external.SourceSplitDataWriter; +import org.apache.flink.connectors.test.common.junit.extensions.ConnectorTestingExtension; +import org.apache.flink.connectors.test.common.junit.extensions.TestCaseInvocationContextProvider; +import org.apache.flink.connectors.test.common.junit.extensions.TestLoggerExtension; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; + +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.TestInstance; +import org.junit.jupiter.api.TestTemplate; +import org.junit.jupiter.api.extension.ExtendWith; + +import java.util.Collection; +import java.util.List; +import java.util.concurrent.ThreadLocalRandom; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.containsInAnyOrder; + +/** A source test template for testing the messages which could be consumed in a unordered way. */ +@ExtendWith({ + ConnectorTestingExtension.class, + TestLoggerExtension.class, + TestCaseInvocationContextProvider.class +}) +@TestInstance(TestInstance.Lifecycle.PER_CLASS) +public abstract class UnorderedSourceTestSuiteBase<T> { Review comment: Nit: I am not sure using inheritance here is strictly necessary currently there is only one class inheriting from it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
