curcur edited a comment on pull request #17187: URL: https://github.com/apache/flink/pull/17187#issuecomment-918905335
Hey @akalash , thanks for updating the PR. Please take a look at my comments. Besides of this, I think this try-catch solution + adding non-null check is not a clean way of solving the problem. In the end, the solution may as complicated as extract all resource initialization outside of the constructor (you have to check each of the member variables whether they are null or not). I think the right way is to extract the resource initialization out of streamtask. But I do understand that may need careful walk through the code and clean-up. So I am also fine to take this bug fix as two steps: 1. Fix the task status transition -> initialization resource leak 2. Fix the leak in the stream task constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
