slinkydeveloper commented on a change in pull request #17204:
URL: https://github.com/apache/flink/pull/17204#discussion_r705984316
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/PlannerMocks.java
##########
@@ -69,8 +77,25 @@ public static FlinkPlannerImpl createDefaultPlanner() {
functionCatalog.asLookup(parser::parseIdentifier),
catalogManager.getDataTypeFactory(),
parser::parseSqlExpression));
+ }
+
+ public FlinkPlannerImpl getPlanner() {
return planner;
}
- private PlannerMocks() {}
+ public ParserImpl getParser() {
+ return parser;
+ }
+
+ public CatalogManager getCatalogManager() {
+ return catalogManager;
+ }
+
+ public Catalog getCurrentCatalog() {
Review comment:
That's a shorthand for testing purpose, in order to avoid cluttering the
test code with the "details" of the `CatalogManager` usage. Does it makes
sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
