matriv commented on a change in pull request #17217:
URL: https://github.com/apache/flink/pull/17217#discussion_r705384003
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java
##########
@@ -120,13 +121,16 @@ public StreamExecSink(
rowtimeFieldIndices.add(i);
}
}
+
+ final boolean isCollectSink = tableSinkSpec.getTableSink() instanceof
CollectDynamicSink;
Review comment:
> `DynamicTableSink` is a public API, so we'd be throwing a method into
it for internal purposes. Such a method also breaks the abstraction, because
you're asking the interface for whether it is a specific implementation.
True, thx!
> Then you'd just have to make that utility public instead, no?
Yep, not insisting, just to me seems a bit cleaner than exposing the class
as public just to enable the `instanceof` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
