dannycranmer commented on a change in pull request #17189:
URL: https://github.com/apache/flink/pull/17189#discussion_r705096592
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
##########
@@ -819,7 +819,7 @@ public void shutdownFetcher() {
LOG.warn("Encountered exception closing record publisher
factory", e);
}
} finally {
- shardConsumersExecutor.shutdownNow();
+ shardConsumersExecutor.shutdown();
Review comment:
For the `POLLING` record consumer you are correct. But for the
`FanOutRecordPublisher` (EFO) it uses a reactive stream and does not check the
`running` flag until subscription is complete/errors (up to 5 minutes). That
being said, the `closeRecordPublisherFactory()` method will kill the Netty
threads and close the client which should cause the `running` flag to be
checked. We would need to check for edge cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
