Airblader commented on a change in pull request #17186:
URL: https://github.com/apache/flink/pull/17186#discussion_r704103712



##########
File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java
##########
@@ -46,6 +55,15 @@
     public static final InputTypeStrategy CURRENT_WATERMARK =
             new CurrentWatermarkInputTypeStrategy();
 
+    /** Input strategy for {@link BuiltInFunctionDefinitions#JSON_OBJECT}. */
+    public static final InputTypeStrategy JSON_OBJECT =

Review comment:
       Yeah, our formatting in general sometimes produces things that you kind 
of just have to get used to. I'm really not a fan of how we format code, but 
it's what we have. Things can usually be made better by splitting it up more, 
of course. This here looks OK to me now (granted, you probably need to have an 
idea of what this is doing).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to