PatrickRen commented on pull request #16940: URL: https://github.com/apache/flink/pull/16940#issuecomment-914952450
Thanks @AHeise for the review! I made some refactor since your last review so you may want to review the PR again. I split changes into 4 commits: - 47e181c changes the return type of `ExternalContext#generateTestData` from `Collection` to `List` because we need to preserve the order of test data - a257fbf improves mismatch descriptions as you commented above. Mismatch description will contain current progress of data validation if test fails - d113d7f adds INFO logs in basic test suite so that it's easier for user to track the behavior and progress of testing framework in logs - b1f1098 is a hotfix for re-enabling tests in `PulsarSourceITCase`, which is disabled temporarily on master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
