[ 
https://issues.apache.org/jira/browse/FLINK-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407214#comment-17407214
 ] 

Timo Walther commented on FLINK-24054:
--------------------------------------

It really depends on the use case. For our current Kafka sink implementation, 
this might not be an issue. But strictly speaking the current behavior is 
incorrect. +I and +U might trigger different downstream logic. [See this 
example|https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/DataStreamJavaITCase.java#L643]
 I had to modify the materialization logic because +U requires a look up by 
primary key, whereas +I should simply be forwarded.

> Let SinkUpsertMaterializer emit +U instead of only +I
> -----------------------------------------------------
>
>                 Key: FLINK-24054
>                 URL: https://issues.apache.org/jira/browse/FLINK-24054
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Runtime
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Blocker
>             Fix For: 1.14.0
>
>
> Currently, {{SinkUpsertMaterializer}} is not able to emit +U's but will 
> always emit +I's. Thus, resulting changelogs are incorrect strictly speaking 
> and only valid when treating +U and +I as similar changes in downstream 
> operators.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to