[
https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335852#comment-15335852
]
ASF GitHub Bot commented on FLINK-3904:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2123
[FLINK-3904] GlobalConfiguration doesn't ensure config has been loaded
This PR contains two commits. The first commit simply checks whether
`loadConfiguration(..)` has been called. The second commit adds additional
tests and forbids malformed XML files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3904
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2123
----
commit cd5ed8a47db2e17f0adeef14752066feb15aa413
Author: Maximilian Michels <m...@apache.org>
Date: 2016-06-17T09:20:03Z
[FLINK-3904] GlobalConfiguration doesn't ensure config has been loaded
commit 3dc3d4d51c7d44be480481236ae45681e6cbe183
Author: Maximilian Michels <m...@apache.org>
Date: 2016-06-17T09:46:11Z
harden checks for loaded config
- Doesn't return the GlobalConfiguration if config couldn't be loaded
- Don't allow malformed xml files
- Adds tests
- Reformat tests
----
> GlobalConfiguration doesn't ensure config has been loaded
> ---------------------------------------------------------
>
> Key: FLINK-3904
> URL: https://issues.apache.org/jira/browse/FLINK-3904
> Project: Flink
> Issue Type: Improvement
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Fix For: 1.1.0
>
>
> By default, {{GlobalConfiguration}} returns an empty Configuration. Instead,
> a call to {{get()}} should fail if the config hasn't been loaded explicitly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
