[ 
https://issues.apache.org/jira/browse/FLINK-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335740#comment-15335740
 ] 

ASF GitHub Bot commented on FLINK-3949:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2119#discussion_r67479777
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
 ---
    @@ -292,6 +294,7 @@ public void run() {
                                                // close and prepare for the 
next iteration
                                                this.format.close();
                                                this.currentSplit = null;
    +                                           completedSplitsCounter.inc();
    --- End diff --
    
    Should we move the increment out of the `finally` clause to avoid counting 
a failed split as processed?


> Collect Metrics in Runtime Operators
> ------------------------------------
>
>                 Key: FLINK-3949
>                 URL: https://issues.apache.org/jira/browse/FLINK-3949
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Local Runtime
>            Reporter: Stephan Ewen
>            Assignee: Chesnay Schepler
>             Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to