[GitHub] [flink] Airblader commented on a change in pull request #16984: [FLINK-23917][table-planner] Project metadata before push-down even if projection push-down is not supported

[GitBox]

Airblader commented on a change in pull request #16984:
URL: https://github.com/apache/flink/pull/16984#discussion_r696581337



##########
File path: 
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -234,7 +234,7 @@ private static RowKind parseRowKind(String 
rowKindShortString) {
 
     public static final AtomicInteger RESOURCE_COUNTER = new AtomicInteger();
 
-    private static final String IDENTIFIER = "values";
+    public static final String IDENTIFIER = "values";

Review comment:
       I'll take this up for the issue to introduce better test infrastructure.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org